[virt-tools-list] [virt-viewer: PATCH] Force display_show_hint() when the display is set

Fabiano Fidêncio fabiano at fidencio.org
Wed Oct 15 21:49:57 UTC 2014


On Tue, Oct 14, 2014 at 5:52 PM, Jonathon Jongsma <jjongsma at redhat.com> wrote:
> On Tue, 2014-10-14 at 16:47 +0200, Fabiano Fidêncio wrote:
>> Since a window is not created at startup for each display, the first
>> display(s) set when the application is opened will never receive and
>> treat the "notify::show-hint" signal on VirtViewerWindow, once the
>> callback is only set when the display is set to the specific window.
>> It causes problems like the "Send Key" menu not activated till an extra
>> display is added. To avoid this problem, let's force a call to
>> display_show_hint() everytime a display is set.
>>
>> Resolves: rhbz#1152468
>> https://bugzilla.redhat.com/show_bug.cgi?id=1152468
>> ---
>>  src/virt-viewer-window.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
>> index 64cf865..df4a200 100644
>> --- a/src/virt-viewer-window.c
>> +++ b/src/virt-viewer-window.c
>> @@ -1327,6 +1327,9 @@ virt_viewer_window_set_display(VirtViewerWindow *self, VirtViewerDisplay *displa
>>                                            G_CALLBACK(virt_viewer_window_desktop_resize), self, 0);
>>          virt_viewer_signal_connect_object(display, "notify::show-hint",
>>                                            G_CALLBACK(display_show_hint), self, 0);
>> +
>> +        display_show_hint(display, NULL, self);
>> +
>>          if (virt_viewer_display_get_enabled(display))
>>              virt_viewer_window_desktop_resize(display, self);
>>      }
>
>
> ACK

Pushed as
910ee34248d98bd9f328c3f3e92120d49f55dedc

Best Regards,
-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list