[virt-tools-list] [PATCH virt-viewer] Fix bug with initial placement of fullscreen windows

Fabiano Fidêncio fabiano at fidencio.org
Wed Oct 15 21:50:34 UTC 2014


On Wed, Oct 15, 2014 at 2:28 AM, Fabiano Fidêncio <fidencio at redhat.com> wrote:
> On Thu, 2014-10-09 at 11:21 -0500, Jonathon Jongsma wrote:
>> The function app_window_try_fullscreen() will lookup the initial monitor
>> for the nth monitor internally, so we should pass in the display ID to the function
>> rather than the mapped monitor ID. This was causing 2 monitors on the
>> same monitor with a configuration like this:
>>
>>     monitor-mapping=1:2;2:1
>> ---
>>  src/virt-viewer-app.c | 3 +--
>>  1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
>> index f0c378d..1402986 100644
>> --- a/src/virt-viewer-app.c
>> +++ b/src/virt-viewer-app.c
>> @@ -885,8 +885,7 @@ ensure_window_for_display(VirtViewerApp *self, VirtViewerDisplay *display)
>>              g_debug("Found a window without a display, reusing for this display...");
>>              virt_viewer_app_set_window_subtitle(self, win, nth);
>>              if (self->priv->fullscreen && !self->priv->kiosk)
>> -                app_window_try_fullscreen(self, win,
>> -                                          virt_viewer_app_get_initial_monitor_for_display(self, nth));
>> +                app_window_try_fullscreen(self, win, nth);
>>          } else {
>>              win = virt_viewer_app_window_new(self, nth);
>>          }
>
> ACK!
>

Pushed as
c64a3c8f707fcbb45c21cb6b4f5fc0b799ca6df5

Best Regards,
-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list