[virt-tools-list] [virt-manager PATCH] virt-manager: close the SPICE main channel on an AUTH error

Cole Robinson crobinso at redhat.com
Mon Oct 27 22:04:19 UTC 2014


On 10/21/2014 09:45 AM, Giuseppe Scrivano wrote:
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1152981
> 
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  virtManager/console.py | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/virtManager/console.py b/virtManager/console.py
> index 67bfe10..030a5c1 100644
> --- a/virtManager/console.py
> +++ b/virtManager/console.py
> @@ -405,6 +405,10 @@ class SpiceViewer(Viewer):
>              self.console.disconnected()
>          elif event == SpiceClientGLib.ChannelEvent.ERROR_AUTH:
>              self.console.activate_auth_page()
> +            for i in self._main_channel_hids:
> +                self.main_channel.handler_disconnect(i)
> +            self._main_channel_hids = []
> +            self.main_channel = None
>          elif event in [SpiceClientGLib.ChannelEvent.ERROR_CONNECT,
>                         SpiceClientGLib.ChannelEvent.ERROR_IO,
>                         SpiceClientGLib.ChannelEvent.ERROR_LINK,
> 

Sorry for the review delay.

This just duplicates similar code in SpiceDisplay.close(), should we call that
instead?

- Cole




More information about the virt-tools-list mailing list