[virt-tools-list] [PATCH 3/3] osdict: merge _OsVariantOsInfo with _OsVariant

[Giuseppe Scrivano]

Cole Robinson <crobinso at redhat.com> writes:

> On 09/09/2014 01:15 PM, Giuseppe Scrivano wrote:
>> Make a new class _OsVariantType which contains only the minimum
>> information shared between a OS type and an OS variant.
>> 
>> As it is not possible anymore to specify the type as the variant name,
>> define some alias names.
>> 
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>>  virtinst/osdict.py | 269 ++++++++++++++++++++++-------------------------------
>>  1 file changed, 110 insertions(+), 159 deletions(-)
>> 
>> diff --git a/virtinst/osdict.py b/virtinst/osdict.py
>> index 242e31c..5818bb9 100644
>> --- a/virtinst/osdict.py
>> +++ b/virtinst/osdict.py
>> @@ -62,6 +62,10 @@ _aliases = {
>>      "ubuntusaucy" : "ubuntu13.10",
>>      "vista" : "winvista",
>>      "winxp64" : "winxp",
>> +
>> +    "linux" : "fedora18",
>> +    "windows" : "win7",
>> +    "solaris" : "solaris11",
>>  }
>>  
>
> Though one tweak here. I'd map "linux" to "generic", "windows" to "winxp", and
> "solaris" to something older like "solaris10". That's more in line with what
> they historically mean.

I've amended this change and pushed the series.

Thanks,
Giuseppe