[virt-tools-list] [PATCH 1/2] Mark all strings for translation in the auth dialog

Christophe Fergeau cfergeau at redhat.com
Fri Sep 12 13:29:08 UTC 2014


Hey,

On Fri, Sep 12, 2014 at 03:04:09PM +0200, Fabiano Fidêncio wrote:
> A few strings weren't marked for translation in the authentication
> dialog.
> ---
>  po/POTFILES.in         | 1 +
>  src/virt-viewer-auth.c | 6 +++---
>  2 files changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/po/POTFILES.in b/po/POTFILES.in
> index 40f8ba4..b6c1c48 100644
> --- a/po/POTFILES.in
> +++ b/po/POTFILES.in
> @@ -5,6 +5,7 @@ src/remote-viewer-main.c
>  src/remote-viewer.c
>  [type: gettext/glade] src/virt-viewer-about.xml
>  src/virt-viewer-app.c
> +src/virt-viewer-auth.c
>  [type: gettext/glade] src/virt-viewer-auth.xml
>  src/virt-viewer-main.c
>  src/virt-viewer-session-spice.c
> diff --git a/src/virt-viewer-auth.c b/src/virt-viewer-auth.c
> index 556a10b..230d720 100644
> --- a/src/virt-viewer-auth.c
> +++ b/src/virt-viewer-auth.c
> @@ -23,6 +23,7 @@
>  #include <config.h>
>  
>  #include <gtk/gtk.h>
> +#include <glib/gi18n.h>
>  #include <string.h>
>  
>  #ifdef HAVE_GTK_VNC
> @@ -74,12 +75,11 @@ virt_viewer_auth_collect_credentials(GtkWindow *window,
>      gtk_widget_set_sensitive(promptPassword, password != NULL);
>  
>      if (address) {
> -        message = g_strdup_printf("Authentication is required for the %s connection to:\n\n"
> -                                  "<b>%s</b>\n\n",
> +        message = g_strdup_printf(_("Authentication is required for the %s connection to:\n\n<b>%s</b>\n\n"),

Translators generally frown upon having markup in translatable strings,
but in this case it's probably easier to keep it there. We can change it
if someone complains. ACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140912/36d1bd24/attachment.sig>


More information about the virt-tools-list mailing list