[virt-tools-list] [PATCH virt-manager] details: Add UI for enabling UEFI via 'customize before install'

Cole Robinson crobinso at redhat.com
Thu Sep 18 12:13:58 UTC 2014

On 09/18/2014 08:03 AM, Giuseppe Scrivano wrote:
> Cole Robinson <crobinso at redhat.com> writes:
>> We expose a simple combobox with two entries: BIOS, and UEFI. The
>> UEFI option is only selectable if 1) libvirt supports the necessary
>> domcapabilities bits, 2) it detects that qemu supports the necessary
>> command line options, and 3) libvirt detects a UEFI binary on the
>> host that maps to a known template via qemu.conf
>> If those conditions aren't met, we disable the UEFI option, and show
>> a small warning icon with an explanatory tooltip.
>> The option can only be changed via New VM->Customize Before Install.
>> For existing x86 VMs, it's a readonly label.
>> ---
>>  ui/details.ui          | 84 ++++++++++++++++++++++++++++++++++++++++++++++----
>>  virtManager/details.py | 72 ++++++++++++++++++++++++++++++++++++++++++-
>>  virtManager/domain.py  | 32 ++++++++++++++++++-
>>  virtinst/support.py    |  3 ++
>>  4 files changed, 183 insertions(+), 8 deletions(-)
> one problem that I've found is that I cannot delete a VM with UEFI as I
> get this error:
> libvirtError: Requested operation is not valid: cannot delete inactive domain with nvram
> since virt-manager first stops a running VM and then undefine it.
> also, since we use VIR_DOMAIN_UNDEFINE_NVRAM (commit
> ead9d3f56dfb32411dac586e6d43dca23d2377f0), should we revert?
> commit e5d2059853a472273b91cdefd224381978249b65
> Author: Giuseppe Scrivano <gscrivan at redhat.com>
> Date:   Thu Sep 11 17:13:31 2014 +0200
>     virt-manager: delete nvram file on VM deletion
> IMHO, it will make more sense to not use VIR_DOMAIN_UNDEFINE_NVRAM and
> use the same mechanism we use for other files virt-manager deletes by
> itself.  What do you think?

The problem with the delete.py support is that in the common case of a
non-root user connecting to qemu:///system, the delete wizard won't be able to
actually delete the nvram file, since it's under /var/lib/libvirt/qemu/nvram.

We could probably use storage APIs to try and import, then delete it, but
that's not wired up yet.

- Cole

More information about the virt-tools-list mailing list