[virt-tools-list] [PATCH 0/2] Revert changes related to numpad accelerators

Fabiano Fidêncio fidencio at redhat.com
Tue Sep 23 11:34:15 UTC 2014


Due to a gtk limitation and bad testing from my side, I've pushed to
patches trying to add support to use Ctrl + {+. -, 0} from numpad to
control zoom-in, zoom-out and zoom-reset. Unfortunately, with the first
patch I've duplicated the menu items relative to the zoom functions.
With the second, hidden the duplicated menu items, we came back to the
same state we had before, with a few more lines of useless code.

So, multiple accelerators in a GTK widget is an API added in the 3.12
and can only be used if the app uses GApplication, what we don't do
right now and probably won't do till we drop GTK+2 support in the
future.

Fabiano Fidêncio (3):
  Revert "Do not show duplicated menu items"
  Revert "Add support to use numpad accelarators for
    zoom-{in.out,reset}"

 src/virt-gtk-compat.h |  3 ---
 src/virt-viewer-app.c |  6 ------
 src/virt-viewer.c     | 19 ++++++++++++-------
 src/virt-viewer.xml   | 36 ------------------------------------
 4 files changed, 12 insertions(+), 52 deletions(-)

-- 
1.9.3




More information about the virt-tools-list mailing list