[virt-tools-list] [PATCH 0/2] Revert changes related to numpad accelerators

Christophe Fergeau cfergeau at redhat.com
Tue Sep 23 12:40:47 UTC 2014

On Tue, Sep 23, 2014 at 01:34:15PM +0200, Fabiano Fidêncio wrote:
> Due to a gtk limitation and bad testing from my side, I've pushed to
> patches trying to add support to use Ctrl + {+. -, 0} from numpad to
> control zoom-in, zoom-out and zoom-reset. Unfortunately, with the first
> patch I've duplicated the menu items relative to the zoom functions.
> With the second, hidden the duplicated menu items, we came back to the
> same state we had before, with a few more lines of useless code.
> So, multiple accelerators in a GTK widget is an API added in the 3.12
> and can only be used if the app uses GApplication, what we don't do
> right now and probably won't do till we drop GTK+2 support in the
> future.

All of this belongs in the commit messages of the revert commits so that
we know why this was reverted in the future. ACK with the commit
messages fixed.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140923/d5867e4d/attachment.sig>

More information about the virt-tools-list mailing list