[virt-tools-list] [virt-viewer: PATCH 2/3] Let's the user set the username in the SPICE auth dialog

Fabiano Fidêncio fabiano at fidencio.org
Tue Sep 23 18:43:20 UTC 2014


On Tue, Sep 23, 2014 at 5:34 PM, Fabiano Fidêncio <fidencio at redhat.com>
wrote:

> Currently virt-viewer doesn't allow the user to set his/her username
> in the SPICE authentication dialog.
> Now, let's auto fill the dialog with the current user name as username
> and leave to the user the possibility to change it, if necessary.
> ---
>  src/virt-viewer-session-spice.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/virt-viewer-session-spice.c
> b/src/virt-viewer-session-spice.c
> index dd96fdf..6b61ce8 100644
> --- a/src/virt-viewer-session-spice.c
> +++ b/src/virt-viewer-session-spice.c
> @@ -509,10 +509,11 @@
> virt_viewer_session_spice_main_channel_event(SpiceChannel *channel
> G_GNUC_UNUSED
>                                    _("invalid password"));
>          self->priv->pass_try++;
>
> +        user = g_strdup (g_get_user_name());
>          ret =
> virt_viewer_auth_collect_credentials(self->priv->main_window,
>                                                     "SPICE",
>                                                     NULL,
> -                                                   NULL, &password);
> +                                                   &user, &password);
>          if (!ret) {
>              g_signal_emit_by_name(session, "session-cancelled");
>          } else {
> --
> 1.9.3
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
>

self NACK!
Typos in the commit message/short log.

-- 
Fabiano Fidêncio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140923/b10bf499/attachment.htm>


More information about the virt-tools-list mailing list