[virt-tools-list] [virt-viewer PATCH v2] Prefer virDomainOpenGraphicsFD for --attach

[Giuseppe Scrivano]

Ján Tomko <jtomko at redhat.com> writes:

> +#if LIBVIR_CHECK_VERSION(1,2,8)
> +    if ((*fd = virDomainOpenGraphicsFD(priv->dom, 0,
> +                                       VIR_DOMAIN_OPEN_GRAPHICS_SKIPAUTH)) >= 0)
> +        return TRUE;
> +
> +    err = virGetLastError();
> +    if (err && err->code != VIR_ERR_NO_SUPPORT) {
> +        g_debug("Error %s", err->message ? err->message : "Unknown");
> +        return TRUE;
> +    }
> +#endif

Would it make sense to check for the virDomainOpenGraphicsFD function in
configure.ac instead of hard-coding the libvirt version here?

Regards,
Giuseppe