[virt-tools-list] [virt-viewer][PATCH v2 2/2] virt-viewer-display-vnc: Set uuid when using VNC

[Fabiano Fidêncio]

On Wed, Apr 29, 2015 at 10:35 AM, Lukas Venhoda <lvenhoda at redhat.com> wrote:
> Notify user, that VNC does not provide uuid.
>
> Set uuid to string "VNC does not provide guid".
> This is more informative then just plain "Unknown".
> User will now know WHY the GUID is unknown, when using remote-viewer.
> ---
> Changes since v1:
>  - No longer calling g_strdup() on _("VNC does not provide GUID").
> ---
>  src/virt-viewer-display-vnc.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/src/virt-viewer-display-vnc.c b/src/virt-viewer-display-vnc.c
> index ad7cec7..c727839 100644
> --- a/src/virt-viewer-display-vnc.c
> +++ b/src/virt-viewer-display-vnc.c
> @@ -117,22 +117,27 @@ virt_viewer_display_vnc_initialized(VncDisplay *vnc G_GNUC_UNUSED,
>                                      VirtViewerDisplay *display)
>  {
>      char *name = NULL;
> +    char *uuid = NULL;
>      VirtViewerSession *session = virt_viewer_display_get_session(display);
>      VirtViewerApp *app = virt_viewer_session_get_app(session);
>
> -    g_object_get(app, "guest-name", &name, NULL);
> +    g_object_get(app, "guest-name", &name, "uuid", &uuid, NULL);
>      if (name == NULL || *name == '\0') {
>          const char * vnc_name = vnc_display_get_name(vnc);
>          if (vnc_name != NULL) {
>              g_object_set(app, "guest-name", vnc_name, NULL);
>          }
>      }
> +    if (uuid == NULL || *uuid == '\0') {
> +        g_object_set(app, "uuid", _("VNC does not provide GUID"), NULL);

Marking the string as translatable has no effect if the file is not
part of po/POTFILES.in.
Please, add this file there :-)

> +    }
>
>      virt_viewer_display_set_show_hint(display,
>                                        VIRT_VIEWER_DISPLAY_SHOW_HINT_READY, TRUE);
>      g_signal_emit_by_name(display, "display-desktop-resize");
>
>      g_free(name);
> +    g_free(uuid);
>  }
>
>  static void
> --
> 2.3.6
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list



-- 
Fabiano Fidêncio