[virt-tools-list] [virt-viewer][PATCH] cosmetic: rename waitvm to waitdom, according to its use

Fabiano Fidencio ffidenci at redhat.com
Wed Aug 5 11:32:34 UTC 2015

----- Original Message -----
> From: "Christophe Fergeau" <cfergeau at redhat.com>
> To: "Fabiano Fidêncio" <fidencio at redhat.com>
> Cc: virt-tools-list at redhat.com
> Sent: Wednesday, August 5, 2015 10:48:42 AM
> Subject: Re: [virt-tools-list] [virt-viewer][PATCH] cosmetic: rename waitvm to waitdom, according to its use
> On Tue, Aug 04, 2015 at 05:29:12PM +0200, Fabiano Fidêncio wrote:
> > --wait is used to wait for a domain to start, not to wait for a VM to
> > start.
> I'm not really making a distinction between domain and VM. Do you mean
> that virt-viewer connects to a libvirt domain, while remote-viewer
> connects to a VM ?

Pretty much. And in case of virt-viewer, if the domain is up but the VM is not, it will wait for the VM anyways, doesn't matter if you pass --wait or not.
You can do a simple test: virt-viewer -c qemu:///system $vm_name_that_is_powered_off ... you will see that we wait for the VM to start in any case, and that's correct according to the docs: https://git.fedorahosted.org/cgit/virt-viewer.git/tree/man/virt-viewer.pod#n43

> Is the rest of the code consistant with its use of
> domain VS VM ? In other words, I'd tend to use both interchangeably, so
> I'm not sure changing it here is really useful.

I do believe it is, but feel free to just ignore the patch if it doesn't make sense for you.

> Christophe

Best Regards,
Fabiano Fidêncio

More information about the virt-tools-list mailing list