[virt-tools-list] [virt-manager PATCH] addstorage: remove _check_ideal_path

Pavel Hrdina phrdina at redhat.com
Tue Aug 11 08:02:26 UTC 2015

On Mon, Aug 10, 2015 at 03:16:16PM -0400, Cole Robinson wrote:
> On 07/23/2015 08:31 AM, Pavel Hrdina wrote:
> > This feature has been added few years ago.  I don't think, that it's a
> > good feature, as it can ask a user to use different storage than he
> > actually wants to use.  One thing is automatically create a new storage
> > for user, if he let as do that, but we shouldn't annoy a user with this
> > question as he probably don't want to use the proposed storage.  For
> > example he would like to use different storage pool or while importing
> > existing storage.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1232599
> > 
> I agree this feature is subpar, I've pushed this patch. This was a workaround
> to try and reuse stranded disk images that usually happen in one of two ways:
> 1) User deletes the VM but not the storage. Used to be easier to screw this up
> with virt-manager since we made you opt in to deleting storage but not so much
> nowadays
> 2) A VM install fails to even launch a VM, and the newly created disk image
> isn't cleaned up. We still don't handle this case, and VM launch issues are
> common over time which happens due to libvirt and qemu regressions. So we
> should fix that too
> Thanks,
> Cole


More information about the virt-tools-list mailing list