[virt-tools-list] [PATCH] Added fix for deleting disk when removing disk from a VM

[Cole Robinson]

On 12/07/2015 11:55 PM, Abhijeet Kasurde wrote:
> Hi Cole,
> 
> On 12/07/2015 11:30 PM, Cole Robinson wrote:
>> On 12/03/2015 07:26 AM, Abhijeet Kasurde wrote:
>>> This fix adds a user dialog box for confirmation specific to disk,
>>> also deletes disk from storage.
>>>
>>> Signed-off-by: Abhijeet Kasurde <akasurde at redhat.com>
>>> ---
>> Thanks for the patch! For reference there's a bug for this:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1058051
> OK.
>> Unfortunately this isn't sufficient. The main problem is it ties together
>> 'delete the media' with 'remove the device from the VM'. There needs to be an
>> option to just remove the device and leave the media intact.
> Can you / anyone suggest workflow or flow diagram for same?

The simplest is just a dialog that asks 'Are you sure you want to remove the
device for %(path)s?' with a checkbox "Delete associated storage file". The
checkbox will always be unchecked by default. If the disk image is in use by
other VMs we should probably show an extra little warning message, or show a
warning icon with a tooltip, like we do in the delete dialog.

In this case it doesn't really fit with the 'Dont ask me again' model, so I
suggest ignoring any settings for that.

I don't do flow diagrams :) but if you take a rough cut at it I can play with
it and give feedback/patches

- Cole