[virt-tools-list] [virt-manager PATCH] cli.py: --force is not supported anymore so do not advertise it

Cole Robinson crobinso at redhat.com
Wed Feb 11 15:25:41 UTC 2015


On 02/11/2015 10:24 AM, Cole Robinson wrote:
> On 02/11/2015 10:16 AM, Giuseppe Scrivano wrote:
>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1177210
>>
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>>  virtinst/cli.py | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/virtinst/cli.py b/virtinst/cli.py
>> index 44fb392..7cacd3d 100644
>> --- a/virtinst/cli.py
>> +++ b/virtinst/cli.py
>> @@ -321,7 +321,7 @@ def validate_disk(dev, warn_overwrite=False):
>>              logging.debug("--force skipping error condition '%s'", msg)
>>              logging.warn(msg)
>>          else:
>> -            fail(msg + _(" (Use --force to override)"))
>> +            fail(msg)
>>  
>>      def check_path_exists(dev):
>>          """
>>
> 
> --force actually does work and still has a valid usecase distinct from the
> prompting stuff. We should resurrect it in the tool --help output and the man
> page for virt-install and virt-clone at least

Longer term I wanted to replace it with an option that allows finegrained
disabling of individual validation checks, but it's very low priority

- Cole




More information about the virt-tools-list mailing list