[virt-tools-list] [virt-manager PATCH 2/2] Do not use vmvga on RHEL

Giuseppe Scrivano gscrivan at redhat.com
Tue Feb 24 18:04:41 UTC 2015


Cole Robinson <crobinso at redhat.com> writes:

>>          video_model = self._os_object.get_videomodel(self)
>> +        if self.conn.stable_defaults() and video_model == 'vmvga':
>> +            video_model == 'vga'

and s/==/=/ here :-(
> ACK but with a test case added that covers this. See
> xmlconfig.py:testOSDeviceDefaultChange as an example. Not sure if you can just
> extend that test case or if it requires a new XML file though

pushed a test case, I had to use a new XML file for it.

Thanks,
Giuseppe




More information about the virt-tools-list mailing list