[virt-tools-list] [PATCH] Add support for PowerPC Little Endian (ppc64le) architecture.

[Prerna Saxena]

Hi,
On Monday 05 January 2015 04:25 PM, Prerna Saxena wrote:
> >From 531dbddb1658df5e6a640c322c2990dbb357383c Mon Sep 17 00:00:00 2001
> From: Prerna Saxena <prerna at linux.vnet.ibm.com>
> Date: Mon, 5 Jan 2015 07:46:18 +0530
> Subject: [PATCH] Add support for PowerPC Little Endian (ppc64le) architecture.
>
> This enables virt-install to create VMs based on ppc64le architecture.
>
> Signed-off-by: Prerna Saxena <prerna at linux.vnet.ibm.com>
> ---
>  virtinst/capabilities.py | 2 +-
>  virtinst/guest.py        | 2 +-
>  virtinst/osxml.py        | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/virtinst/capabilities.py b/virtinst/capabilities.py
> index 167f613..729fa73 100644
> --- a/virtinst/capabilities.py
> +++ b/virtinst/capabilities.py
> @@ -395,7 +395,7 @@ class Domain(object):
>          if not conn.is_test() and not conn.is_qemu():
>              return None
>
> -        if capsguest.arch == "ppc64" and "pseries" in self.machines:
> +        if capsguest.arch in ["ppc64", "ppc64le"] and "pseries" in self.machines:
>              return "pseries"
>          if capsguest.arch in ["armv7l", "aarch64"]:
>              if "virt" in self.machines:
> diff --git a/virtinst/guest.py b/virtinst/guest.py
> index 9015cb1..6602392 100644
> --- a/virtinst/guest.py
> +++ b/virtinst/guest.py
> @@ -614,7 +614,7 @@ class Guest(XMLBuilder):
>              return
>          if self.os.is_container():
>              return
> -        if self.os.arch not in ["x86_64", "i686", "ppc64", "ia64"]:
> +        if self.os.arch not in ["x86_64", "i686", "ppc64", "ppc64le","ia64"]:
>              return
>          self.add_device(VirtualGraphics(self.conn))

Pylint points that I missed a whitespace after "ppc64le".  I am waiting on community feedback for this patch. I will include this change in the next version.

> diff --git a/virtinst/osxml.py b/virtinst/osxml.py
> index 78b12da..f9eb9ee 100644
> --- a/virtinst/osxml.py
> +++ b/virtinst/osxml.py
> @@ -63,7 +63,7 @@ class OSXML(XMLBuilder):
>          return self.is_arm() and self.machine == "virt"
>
>      def is_ppc64(self):
> -        return self.arch == "ppc64"
> +        return self.arch == "ppc64" or self.arch == "ppc64le"
>      def is_pseries(self):
>          return self.is_ppc64 and self.machine == "pseries"
>

-- 
Prerna Saxena

Linux Technology Centre,
IBM Systems and Technology Lab,
Bangalore, India