[virt-tools-list] [PATCH] fix source name attribute for gluster volumes

[Anatoly Belikov]

I got this error when i made few subdirectories in gluster volume, and
changed <dir path /> in  libvirt pool xml accordingly.
Here is command line and debug output in attached file:
 python /usr/share/virt-manager/virt-install  --name=vm3vv --disk
vol=gluster-pool/vm3vv.qcow2,bus=ide,cache=none --ram=1024 --vcpus=1
--cdrom=/var/glusterfs/vm_images_and_config/iso/msvs3_12.2.iso --debug
--network=bridge:br0,model=virtio --noautoconsole >> virtinstall.log 2>&1

gluster-pool.xml is pool definition from /etc/libvirt/storage

2015-01-27 21:52 GMT+03:00 Cole Robinson <crobinso at redhat.com>:

> On 01/27/2015 08:10 AM, Anatoly.Belikov.wormblood at gmail.com wrote:
> > From: Anatoly Belikov <wormblood at gmail.com>
> >
> > ---
> >  virtinst/devicedisk.py | 6 +++++-
> >  1 file changed, 5 insertions(+), 1 deletion(-)
> >
> > diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py
> > index ac03716..df2befc 100644
> > --- a/virtinst/devicedisk.py
> > +++ b/virtinst/devicedisk.py
> > @@ -627,7 +627,11 @@ class VirtualDisk(VirtualDevice):
> >
> >          path = ""
> >          if poolxml.source_name:
> > -            path += poolxml.source_name + "/"
> > +            path += poolxml.source_name
> > +            if poolxml.type == poolxml.TYPE_GLUSTER:
> > +                path += poolxml.source_path
> > +            if not path.endswith('/'):
> > +                path += "/"
> >          path += volxml.name
> >          self.source_name = path
> >          self.type = "network"
> >
>
> Thanks for the patch. Can you describe how to reproduce this issue? If via
> virt-install, please provide the full command line and debug output, since
> I'd
> like to add a test case that covers this
>
> Thanks,
> Cole
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
>



-- 
С уважением
А. Беликов
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20150128/9b954c31/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: virtinstall.log
Type: text/x-log
Size: 8330 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20150128/9b954c31/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gluster-pool.xml
Type: text/xml
Size: 600 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20150128/9b954c31/attachment.xml>