[virt-tools-list] [PATCH virt-viewer 2/4] Remove unnecessary parameter from virt_viewer_window_resize()

Jonathon Jongsma jjongsma at redhat.com
Wed Jul 15 18:11:30 UTC 2015


ACK


On Tue, 2015-07-14 at 16:13 +0200, Pavel Grunt wrote:
> Since c3cbdef888cc823e92140027d38378f40ccd4174 virt_viewer_window_resize
> is always called with keep_win_size = FALSE.
> ---
>  src/virt-viewer-window.c | 11 +++++------
>  1 file changed, 5 insertions(+), 6 deletions(-)
> 
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index 71e6575..153e707 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -66,7 +66,7 @@ void virt_viewer_window_menu_preferences_cb(GtkWidget *menu, VirtViewerWindow *s
>  /* Internal methods */
>  static void virt_viewer_window_enable_modifiers(VirtViewerWindow *self);
>  static void virt_viewer_window_disable_modifiers(VirtViewerWindow *self);
> -static void virt_viewer_window_resize(VirtViewerWindow *self, gboolean keep_win_size);
> +static void virt_viewer_window_resize(VirtViewerWindow *self);
>  static void virt_viewer_window_toolbar_setup(VirtViewerWindow *self);
>  static GtkMenu* virt_viewer_window_get_keycombo_menu(VirtViewerWindow *self);
>  static void virt_viewer_window_get_minimal_dimensions(VirtViewerWindow *self, guint *width, guint *height);
> @@ -365,7 +365,7 @@ virt_viewer_window_desktop_resize(VirtViewerDisplay *display G_GNUC_UNUSED,
>          self->priv->desktop_resize_pending = TRUE;
>          return;
>      }
> -    virt_viewer_window_resize(self, FALSE);
> +    virt_viewer_window_resize(self);
>  }
>  
>  static gint
> @@ -426,7 +426,7 @@ virt_viewer_window_queue_resize(VirtViewerWindow *self)
>   * scale down to fit, maintaining aspect ratio
>   */
>  static void
> -virt_viewer_window_resize(VirtViewerWindow *self, gboolean keep_win_size)
> +virt_viewer_window_resize(VirtViewerWindow *self)
>  {
>      GdkRectangle fullscreen;
>      GdkScreen *screen;
> @@ -489,8 +489,7 @@ virt_viewer_window_resize(VirtViewerWindow *self, gboolean keep_win_size)
>      virt_viewer_display_set_desktop_size(VIRT_VIEWER_DISPLAY(priv->display),
>                                           width, height);
>  
> -    if (!keep_win_size)
> -        virt_viewer_window_queue_resize(self);
> +    virt_viewer_window_queue_resize(self);
>  }
>  
>  static void
> @@ -1433,7 +1432,7 @@ virt_viewer_window_show(VirtViewerWindow *self)
>      gtk_widget_show(self->priv->window);
>  
>      if (self->priv->desktop_resize_pending) {
> -        virt_viewer_window_resize(self, FALSE);
> +        virt_viewer_window_resize(self);
>          self->priv->desktop_resize_pending = FALSE;
>      }
>  





More information about the virt-tools-list mailing list