[virt-tools-list] [PATCH virt-viewer v2 0/3] Zoom related fixes

Pavel Grunt pgrunt at redhat.com
Thu Jul 16 14:31:05 UTC 2015


Hi,
this small set of patches contains fixes for zoom related problems in virt-viewer.
The first patch fixes zoom operations in VNC guest when the window was resized [0].
The last patch enables resizing the window to any size [1] (allowed by the window manager)
by removing a part of the code which has been there since 2009. It also fixes problems
with wrong zoom used just after the connecting [2].

v2: just removed PATCH 3 of v1

I did a couple of tests to summarize changes:
1 - connect to a guest having greater desktop resolution than the client
2 - resize the window to be bigger than the client's screen
3 - zoom out, resize the window to resize the guest, set normal zoom
4 - keep zooming in to reach the maximal zoom then set normal zoom

GNOME2 - RHEL6.7
__| Before                        | After
1 | resized to fit into screen    | resized to fit into screen
2 | scaled down                   | resized to bigger than screen
3 | resized to bigger than screen | resized to bigger than screen
4 | no change                     | no change

GNOME3 - RHEL7.2
__| Before                        | After
1 | resized to fit into screen    | resized to fit into screen
2 | scaled down                   | resized to bigger than screen
3 | resized to fit into screen    | resized to fit into screen
4 | shrunk & scaled down          | shrunk

Windows 7 - 1 display
__| Before                        | After
1 | resized to fit into screen    | resized to fit into screen
2 | not possible                  | not possible
3 | scaled down                   | resized to fit into screen
4 | shrunk & scaled down          | shrunk

Windows 7 - 2 displays
__| Before                        | After
1 | scaled down                   | no change of guest's resolution
2 | scaled down                   | resized to bigger than screen
3 | resized to bigger than screen | resized to bigger than screen
4 | shrunk & scaled down          | shrunk

Xfce - Fedora 23 (rawhide)
__| Before                        | After
1 | scaled down                   | no change of guest's resolution
2 | scaled down                   | resized to bigger than screen
3 | resized to bigger than screen | resized to bigger than screen
4 | no change                     | no change

Pavel

[0] https://bugs.freedesktop.org/show_bug.cgi?id=90582
[1] https://bugzilla.redhat.com/show_bug.cgi?id=1205804
[2] https://bugzilla.redhat.com/show_bug.cgi?id=1221501

Pavel Grunt (3):
  virt-viewer-window: Change zoom with respect to real zoom
  Remove unnecessary parameter from virt_viewer_window_resize()
  virt-viewer-window: Allow to resize window to any size

 src/virt-viewer-window.c | 100 ++++++++++-------------------------------------
 1 file changed, 20 insertions(+), 80 deletions(-)

-- 
2.4.5




More information about the virt-tools-list mailing list