[virt-tools-list] [virt-viewer][PATCH 2/6] events: remove timeout and handle from arrays

Christophe Fergeau cfergeau at redhat.com
Fri Jul 17 16:18:46 UTC 2015


On Fri, Jul 17, 2015 at 06:15:19PM +0200, Christophe Fergeau wrote:
> > @@ -115,7 +112,7 @@ int virt_viewer_events_add_handle(int fd,
> >                                    virt_viewer_events_dispatch_handle,
> >                                    data);
> >  
> > -    handles[nhandles++] = data;
> > +    g_ptr_array_add(handles, data);
> >  
> >      return data->watch;
> >  }
> > @@ -123,10 +120,22 @@ int virt_viewer_events_add_handle(int fd,
> >  static struct virt_viewer_events_handle *
> >  virt_viewer_events_find_handle(int watch)
> 
> any reason for not keeping the guint *idx arg added in the source
> commit?
> 

Ah ok you squashed
https://libvirt.org/git/?p=libvirt-glib.git;a=commitdiff;h=1fb34633ef3b318ea678b775d5e47debc98d2184
in

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20150717/385bedd8/attachment.sig>


More information about the virt-tools-list mailing list