[virt-tools-list] [virt-manager PATCH] virtManager/create: update capsinfo sooner in set_conn_state

Cole Robinson crobinso at redhat.com
Tue Jul 21 15:56:12 UTC 2015


On 07/20/2015 03:19 AM, Pavel Hrdina wrote:
> We need to update/initialize the capsinfo sooner in that function to be
> able to call has_install_options().
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1244566
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  virtManager/create.py | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/virtManager/create.py b/virtManager/create.py
> index 7021b0c..bb556fc 100644
> --- a/virtManager/create.py
> +++ b/virtManager/create.py
> @@ -504,6 +504,9 @@ class vmmCreate(vmmGObjectUI):
>          self.widget("startup-error-box").hide()
>          self.widget("create-forward").set_sensitive(True)
>  
> +        self.conn.invalidate_caps()
> +        self.change_caps()
> +
>          if not self.capsinfo.guest.has_install_options():
>              error = _("No hypervisor options were found for this "
>                        "connection.")
> @@ -517,8 +520,6 @@ class vmmCreate(vmmGObjectUI):
>  
>          # A bit out of order, but populate arch + hv lists so we can
>          # determine a default
> -        self.conn.invalidate_caps()
> -        self.change_caps()
>          self.populate_hv()
>          self.populate_arch()
>  
> 

ACK, pushed now

- Cole




More information about the virt-tools-list mailing list