[virt-tools-list] [PATCH virt-viewer 1/2] configure: Enable spice-gtk when have all necessary spice packages

[Christophe Fergeau]

Hey,

On Mon, Jun 29, 2015 at 01:18:19PM +0200, Pavel Grunt wrote:
> Avoid failing configure with an older spice-protocol

To be honest, took me a while to understand what this commit was meant
to achieve :-/
Maybe a more descriptive changelog would help:

"When neither --with-spice-gtk=yes nor --with-spice-gtk=no is used,
spice-gtk is supposed to be automatically enabled/disabled depending
on its availability. However, this is not perfectly working as once
spice-gtk has been detected as available, configure will fail if
spice-protocol or spice-controller ar too old. In this case, spice-gtk
support should just be disabled rather than configure failing"

Maybe this is too verbose ;)



> ---
>  configure.ac | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 3399129..df0053d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -180,7 +180,8 @@ AC_ARG_WITH([spice-gtk],
>  
>  AS_IF([test "x$with_spice_gtk" != "xno"],
>        [PKG_CHECK_MODULES(SPICE_GTK,
> -                         [spice-client-gtk-$SPICE_GTK_API_VERSION >= $SPICE_GTK_REQUIRED],
> +                         [spice-client-gtk-$SPICE_GTK_API_VERSION >= $SPICE_GTK_REQUIRED
> +                          spice-controller spice-protocol >= $SPICE_PROTOCOL_REQUIRED],
>                           [have_spice_gtk=yes], [have_spice_gtk=no])],

The individual checks for spice-protocol and spice-controller could be
removed from the block which comes below, but this is all revamped in
the next commit anyway, so no big deal.

ACK.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20150723/3ad1fd54/attachment.sig>