[virt-tools-list] [RFC virt-viewer 07/12] test: Add test case for virt_viewer_compare_buildid

Christophe Fergeau cfergeau at redhat.com
Tue Jun 2 14:29:24 UTC 2015


---
 src/Makefile.am            | 19 ++++++++++++++++
 src/test-version-compare.c | 56 ++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 75 insertions(+)
 create mode 100644 src/test-version-compare.c

diff --git a/src/Makefile.am b/src/Makefile.am
index e76f5bc..3a8a9c8 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -76,6 +76,25 @@ COMMON_SOURCES +=					\
 	ovirt-foreign-menu.h ovirt-foreign-menu.c
 endif
 
+check_PROGRAMS = test-version-compare
+TESTS = $(check_PROGRAMS)
+test_version_compare_SOURCES =				\
+	virt-viewer-util.c				\
+	virt-viewer-util.h				\
+	test-version-compare.c				\
+	$(NULL)
+test_version_compare_LDFLAGS =			\
+	$(GLIB2_LIBS)				\
+	$(GTK_LIBS)				\
+	$(LIBXML2_LIBS)				\
+	$(NULL)
+test_version_compare_CFLAGS =			\
+	$(GLIB2_CFLAGS) 			\
+	$(GTK_CFLAGS)				\
+	$(LIBXML2_CFLAGS)			\
+	$(WARN_CFLAGS)				\
+	$(NULL)
+
 if HAVE_LIBVIRT
 bin_PROGRAMS += virt-viewer
 virt_viewer_SOURCES =					\
diff --git a/src/test-version-compare.c b/src/test-version-compare.c
new file mode 100644
index 0000000..8ffb463
--- /dev/null
+++ b/src/test-version-compare.c
@@ -0,0 +1,56 @@
+/* -*- Mode: C; c-basic-offset: 4; indent-tabs-mode: nil -*- */
+/*
+ * Virt Viewer: A virtual machine console viewer
+ *
+ * Copyright (C) 2015 Red Hat, Inc.
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307  USA
+ */
+#include <glib.h>
+#include <virt-viewer-util.h>
+
+gboolean doDebug = FALSE;
+
+int main(void)
+{
+    g_assert(virt_viewer_compare_buildid("1-1", "1-1") == 0);
+    g_assert(virt_viewer_compare_buildid("1-1", "1-1.1") == -1);
+    g_assert(virt_viewer_compare_buildid("1-1", "1-2") == -1);
+    g_assert(virt_viewer_compare_buildid("1-3", "1-2") == 1);
+    g_assert(virt_viewer_compare_buildid("2-3", "1-2") == 1);
+    g_assert(virt_viewer_compare_buildid("2-3", "3-2") == -1);
+    g_assert(virt_viewer_compare_buildid("2-3", "3-4") == -1);
+    g_assert(virt_viewer_compare_buildid("4-3", "3-4") == 1);
+
+    g_assert(virt_viewer_compare_buildid("4-", "3-4") == 1);
+    g_assert(virt_viewer_compare_buildid("4-3", "3-") == 1);
+    g_assert(virt_viewer_compare_buildid("-3", "3-4") == -1);
+    g_assert(virt_viewer_compare_buildid("4-3", "-4") == 1);
+    g_assert(virt_viewer_compare_buildid("-3", "-4") == -1);
+    g_assert(virt_viewer_compare_buildid("4", "3-4") == 1);
+    g_assert(virt_viewer_compare_buildid("4-3", "3") == 1);
+    g_assert(virt_viewer_compare_buildid("3", "3-4") == -1);
+    g_assert(virt_viewer_compare_buildid("4-3", "4") == 1);
+    g_assert(virt_viewer_compare_buildid("-3", "-4") == -1);
+
+    /* These trigger runtime warnings */
+    g_assert(virt_viewer_compare_buildid("-3", "-") == 1);
+    g_assert(virt_viewer_compare_buildid("", "-") == 0);
+    g_assert(virt_viewer_compare_buildid("", "") == 0);
+    g_assert(virt_viewer_compare_buildid("", NULL) == 0);
+    g_assert(virt_viewer_compare_buildid(NULL, NULL) == 0);
+
+    return 0;
+}
-- 
2.4.2




More information about the virt-tools-list mailing list