[virt-tools-list] [RFC virt-viewer 03/12] vv-file: Add VirtViewerFile::versions

Christophe Fergeau cfergeau at redhat.com
Wed Jun 3 15:23:34 UTC 2015


On Wed, Jun 03, 2015 at 03:44:58PM +0200, Pavel Grunt wrote:
> > +GHashTable*
> > +virt_viewer_file_get_versions(VirtViewerFile* self)
> > +{
> > +    GHashTable *versions;
> > +    gchar **versions_str;
> > +    gsize length;
> > +    unsigned int i;
> > +
> > +    versions = g_hash_table_new_full(g_str_hash, g_str_equal, g_free, 
> > g_free);
> > +    versions_str = virt_viewer_file_get_string_list(self, MAIN_GROUP,
> > +                                                     "versions", &length);
> > +    for (i = 0; i < length; i++) {
> > +        GStrv tokens;
> > +
> > +        if (versions_str[i] == NULL) {
> > +            g_warn_if_reached();
> > +            break;
> > +        }
> > +        tokens = g_strsplit(versions_str[i], ":", 2);
> > +        if (g_strv_length(tokens) != 2) {
> > +            g_warn_if_reached();
> > +            continue;
> > +        }
> > +        g_debug("Minimum version '%s' for OS id '%s'", tokens[0], tokens[1]);
> 
> not g_debug("Minimum version '%s' for OS id '%s'", tokens[1], tokens[0]); ?

That's correct, I've fixed it, thanks!

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20150603/4af6810b/attachment.sig>


More information about the virt-tools-list mailing list