[virt-tools-list] [virt-viewer v2 0/9] Add more sophisticated version check to .vv files

Jonathon Jongsma jjongsma at redhat.com
Thu Jun 4 15:21:16 UTC 2015


This new series looks good to me.

On Wed, 2015-06-03 at 18:13 +0200, Christophe Fergeau wrote:
> Hey,
> 
> This is the v2 of my path series adding 'versions' and 'newer-version-url' to .vv files.
> I've removed 2 unneeded patches, and merged the 2 patch related to virt_viewer_compare_buildid
> While at it I've removed the magic G_MAXINT usage in the version comparison
> function, which makes the code simpler. I've adjusted the test case for the
> version comparison as virt_viewer_compare_buildid now returns <0 0 or >0 rather
> than just -1, 0, 1.
> And the small bug in a g_debug message pointed out by Pavel has been fixed too.
> 
> Merged patches:
> 06/12] util: Replace virt_viewer_compare_version with _compare_buildid
> 08/12] util: Improve empty string handling in virt_viewer_compare_buildid
> 
> Removed patches:
> 09/12] util: Add some runtime testing of virt_viewer_compare_buildid
> 10/12] spec: Take Epoch into account in package buildid
> 
> Christophe
> 
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list





More information about the virt-tools-list mailing list