[virt-tools-list] [virt-manager PATCH v2 1/2] clitest: upated virt-xml test --console target_type from serial to sclp

Chen, Hanxiao chenhanxiao at cn.fujitsu.com
Tue Jun 9 02:04:28 UTC 2015



> -----Original Message-----
> From: Cole Robinson [mailto:crobinso at redhat.com]
> Sent: Tuesday, June 09, 2015 5:44 AM
> To: Chen, Hanxiao/陈 晗霄; virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH v2 1/2] clitest: upated virt-xml
> test --console target_type from serial to sclp
> 
> On 06/07/2015 10:55 PM, Chen Hanxiao wrote:
> > libvirt commit:
> > 8728a78e904de7ddfa32b7761b40d6339fa15030
> > Always add 'console' matching the 'serial' device
> >
> > If --console target_type=serial, nothing changed.
> > We had to update the test case.
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> Thanks, but these patches are still a bit less than ideal, since they change
> the test suite to _only_ work with very recent libvirt.git
> 
> I pushed a similar change that fixes the test suite to work both before and
> after the libvirt.git change.
> 

Thanks, your patch is more close to the design of that libvirt's commit.

Regards,
- Chen




More information about the virt-tools-list mailing list