[virt-tools-list] [PATCH] webdav support is not available for Windows

[Pavel Grunt]

On Mon, 2015-06-15 at 17:29 -0400, Fabiano Fidencio wrote:
> 
> ----- Original Message -----
> > From: "Victor Toso" <victortoso at redhat.com>
> > To: "Fabiano Fidêncio" <fidencio at redhat.com>
> > Cc: virt-tools-list at redhat.com
> > Sent: Monday, June 15, 2015 11:16:14 PM
> > Subject: Re: [virt-tools-list] [PATCH] webdav support is not available for 
> > Windows
> > 
> > Hi,
> > 
> > On Mon, Jun 15, 2015 at 11:01:03PM +0200, Fabiano Fidêncio wrote:
> > > As there is no Phodav support for Windows, spice-gtk ends up being
> > > built without webdav support, what can cause a build breakage on
> > > virt-viewer when compiled using mingw.
> > > 
> > > The build failure is:
> > > virt-viewer-session-spice.c: In function
> > > 'virt_viewer_session_spice_can_share_folder':
> > > virt-viewer-session-spice.c:165:64: error: 'SPICE_CHANNEL_WEBDAV'
> > > undeclared (first use in this function)
> > >      return spice_session_has_channel_type(self->priv->session,
> > >      SPICE_CHANNEL_WEBDAV);
> > > 
> > > The mingw-spice-gtk version used is 0.29.
> > 
> > This error is related to outdated spice-protocol. The
> > SPICE_CHANNEL_WEBDAV should be defined on spice-protocol 0.12.7.

And virt-viewer currently requires spice-protocol 0.10.1

> > 
> > But yes, we don't have mingw-phodav atm.
> 
> Aha. So I am self-nacking this patch and updating the mingw-spice-protocol 
> package for f22.
> 
> > 
> > > ---
> > >  src/virt-viewer-session-spice.c | 10 +++++++++-
> > >  1 file changed, 9 insertions(+), 1 deletion(-)
> > > 
> > > diff --git a/src/virt-viewer-session-spice.c
> > > b/src/virt-viewer-session-spice.c
> > > index f763975..2690ebd 100644
> > > --- a/src/virt-viewer-session-spice.c
> > > +++ b/src/virt-viewer-session-spice.c
> > > @@ -158,11 +158,15 @@ 
> > > virt_viewer_session_spice_mime_type(VirtViewerSession
> > > *self G_GNUC_UNUSED)
> > >  }
> > >  
> > >  static gboolean
> > > -virt_viewer_session_spice_can_share_folder(VirtViewerSession *session)
> > > +virt_viewer_session_spice_can_share_folder(VirtViewerSession *session
> > > G_GNUC_UNUSED)
> > >  {
> > > +#ifndef G_OS_WIN32
> > >      VirtViewerSessionSpice *self = VIRT_VIEWER_SESSION_SPICE(session);
> > >  
> > >      return spice_session_has_channel_type(self->priv->session,
> > >      SPICE_CHANNEL_WEBDAV);
> > > +#else
> > > +    return FALSE;
> > > +#endif
> > >  }
> > >  
> > >  static void
> > > @@ -986,6 +990,7 @@ name_changed(GObject *gobject G_GNUC_UNUSED,
> > >      g_free(name);
> > >  }
> > >  
> > > +#ifndef G_OS_WIN32
> > >  static void
> > >  update_share_folder(VirtViewerSessionSpice *self)
> > >  {
> > > @@ -1010,6 +1015,7 @@ update_share_folder(VirtViewerSessionSpice *self)
> > >  
> > >      g_list_free(channels);
> > >  }
> > > +#endif
> > >  
> > >  VirtViewerSession *
> > >  virt_viewer_session_spice_new(VirtViewerApp *app, GtkWindow *main_window)
> > > @@ -1030,9 +1036,11 @@ virt_viewer_session_spice_new(VirtViewerApp *app,
> > > GtkWindow *main_window)
> > >                                        G_CALLBACK(uuid_changed), self, 0);
> > >      virt_viewer_signal_connect_object(self->priv->session, 
> > > "notify::name",
> > >                                        G_CALLBACK(name_changed), self, 0);
> > > +#ifndef G_OS_WIN32
> > >      virt_viewer_signal_connect_object(self, "notify::share-folder",
> > >                                        G_CALLBACK(update_share_folder),
> > >                                        self,
> > >                                        G_CONNECT_SWAPPED);
> > > +#endif
> > >  
> > >      g_object_bind_property(self->priv->session, "shared-dir",
> > >                             self, "shared-folder",
> > > --
> > > 2.4.3
> > > 
> > > _______________________________________________
> > > virt-tools-list mailing list
> > > virt-tools-list at redhat.com
> > > https://www.redhat.com/mailman/listinfo/virt-tools-list
> > 
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list