[virt-tools-list] [remote-viewer PATCH 0/7 v3] remote-viewer: Rewrite of connect dialog

[Pavel Grunt]

Pushed

On Mon, 2015-06-15 at 13:52 -0500, Jonathon Jongsma wrote:
> Thanks, looks good.
> 
> ACK!
> 
> 
> On Mon, 2015-06-15 at 12:47 +0200, Lukas Venhoda wrote:
> > Connect dialog was hardcoded, and sometimes didn't have a parent window.
> > 
> > Changed dialog to a window.
> > Moved UI definition from code to XML.
> > Moved the "dialog" code to its own module.
> > Fixed some issues with the original dialog.
> > 
> > ---
> > Changes since v2
> >  - Changed Makefile commit to one file per line
> >  - Changed response type from GtkResponseType to gboolean
> >  - Enforce uri == NULL instead of free
> >  - Fixed missing space
> >  - Changed error retval to FALSE
> >     - It's OK to just quit the program
> > 
> > Changes since v1
> >  - Split the 3 patches into 7
> >  - Hopefully this new split makes more sense
> >  - Adressed some more issues
> > ---
> > 
> > Lukas Venhoda (7):
> >   remote-viewer: Connect dialog moved to its own file
> >   remote-viewer-connect: Changed response to gboolean
> >   remote-viewer-connect: Check if uri is NULL
> >   remote-viewer-connect: Changed dialog into a window
> >   remote-viewer-connect: Changed hardcoded UI into XML
> >   remote-viewer-connect: Fixed reselecting in recent chooser
> >   remote-viewer-connect: Address entry is now required
> > 
> >  po/POTFILES.in                |   1 +
> >  src/Makefile.am               |   3 +
> >  src/remote-viewer-connect.c   | 261 
> > ++++++++++++++++++++++++++++++++++++++++++
> >  src/remote-viewer-connect.h   |  36 ++++++
> >  src/remote-viewer-connect.xml | 152 ++++++++++++++++++++++++
> >  src/remote-viewer.c           | 162 +-------------------------
> >  6 files changed, 455 insertions(+), 160 deletions(-)
> >  create mode 100644 src/remote-viewer-connect.c
> >  create mode 100644 src/remote-viewer-connect.h
> >  create mode 100644 src/remote-viewer-connect.xml
> > 
> > --
> > 2.4.2
> > 
> > _______________________________________________
> > virt-tools-list mailing list
> > virt-tools-list at redhat.com
> > https://www.redhat.com/mailman/listinfo/virt-tools-list
> 
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list