[virt-tools-list] [PATCHv3 virt-viewer 00/10] shared folder preferences

Fabiano Fidêncio fabiano at fidencio.org
Thu Mar 5 20:24:13 UTC 2015


On Thu, Mar 5, 2015 at 8:12 PM, Marc-André Lureau
<marcandre.lureau at gmail.com> wrote:
> Hi
>
> A small series to do basic configuration of folder sharing with Spice:
>
>   - dialog allows to enable/disable share folder, change folder, and set
>   read-only
>   - shared folder is disabled by default
>   - default shared folder is spice-gtk default (~/Public)
>   - no settings are saved, and it's not configurable by .vv files either
>
> V3:
>   - updated after code review from Fabiano
>
> Marc-André Lureau (10):
>   misc: add a missing "static" for function
>   Add a few session properties for share folder
>   Bump spice-gtk to 0.28
>   spice: sync share folder preferences with session
>   spice: enable/disable share folder
>   Add preferences dialog UI file
>   Show preferences dialog
>   Sync preferences widgets with session properties
>   Add virt_viewer_session_can_share_folder()
>   Enable share folder widgets if supported by session
>
>  configure.ac                    |   2 +-
>  src/Makefile.am                 |   1 +
>  src/virt-viewer-app.c           |  89 +++++++++++++++++++++++++-
>  src/virt-viewer-app.h           |   1 +
>  src/virt-viewer-preferences.xml | 134 ++++++++++++++++++++++++++++++++++++++++
>  src/virt-viewer-session-spice.c |  45 +++++++++++++-
>  src/virt-viewer-session.c       |  70 +++++++++++++++++++++
>  src/virt-viewer-session.h       |   2 +
>  src/virt-viewer-window.c        |   9 +++
>  src/virt-viewer.xml             |   9 +++
>  10 files changed, 359 insertions(+), 3 deletions(-)
>  create mode 100644 src/virt-viewer-preferences.xml
>
> --
> 2.1.0
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list


ACK the series with the small changes on patches 05/10 and 10/10 (and
considering the 09/10 was not changed since my first review, as I
didn't receive its v3).

Best Regards,
-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list