[virt-tools-list] [PATCH virt-viewer v3 2/2] ovirt: Allow to cancel authentication without showing error dialog

Pavel Grunt pgrunt at redhat.com
Thu Mar 19 08:50:42 UTC 2015


> 
> So, did you investigate whether it would be possible to modify
> libgovirt / librest to return a 'CANCELLED' error status (or similar)
> from ovirt_proxy_fetch_api() so that we don't need to track this
> ourselves with an extra struct? That seems like a cleaner long-term
> solution.
> 
> But this patch is fine for the current behavior. ACK.
> 
> Jonathon
> 

I should have mentioned in the patch:

According to [1] the "authenticate" signal returns FALSE when credentials are not set, returns TRUE when they are set, I don't see a way how to "forward" info why they weren't set.
However the "CANCELLED" error exists in librest [2] so maybe implementing new signal / api in librest and handling REST_PROXY_ERROR_CANCELLED in libgovirt is possible solution

[1] https://developer.gnome.org/rest/0.7/RestProxy.html#RestProxy-authenticate
[2] https://developer.gnome.org/rest/0.7/RestProxy.html#REST-PROXY-ERROR:CAPS




More information about the virt-tools-list mailing list