[virt-tools-list] [PATCH 1/2] Do not show a display when virt-viewer --direct fails

Fabiano Fidêncio fabiano at fidencio.org
Wed Mar 25 16:42:03 UTC 2015


Christophe,

On Wed, Mar 25, 2015 at 4:47 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Wed, Mar 25, 2015 at 03:54:08PM +0100, Fabiano Fidêncio wrote:
>> When --direct fails the expected behavior is to report an error and
>> close the dialog, instead of the current behavior, that shows a dialog
>> and waits for the guest to connect.
>
> Is it specific to --direct though? It looks to me that we should never
> try to wait if virt_viewer_update_display() fails. I think we used to do
> that before commits 6100d08 / 9e2f9ea0

Hmmm. Interesting, at least :-)
I have tested the behavior before that commits and looks like it must
be specific to --direct. The other cases should wait for a VM.

Best Regards,
-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list