[virt-tools-list] [virt-viewer 7/8 v4] virt-viewer: Do not wait for a guest that will never show up

Fabiano Fidêncio fidencio at redhat.com
Fri Mar 27 16:21:57 UTC 2015


All the situations where virt_viewer_update_display() can fail are
those when we won't be able to connect regardless of what changes on the
remote host. So, propagate the error instead of waiting for the guest to
start.

Related: rhbz#1085216
---
 src/virt-viewer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/virt-viewer.c b/src/virt-viewer.c
index 93449a6..e297757 100644
--- a/src/virt-viewer.c
+++ b/src/virt-viewer.c
@@ -771,7 +771,7 @@ virt_viewer_initial_connect(VirtViewerApp *app, GError **error)
     }
 
     if (!virt_viewer_update_display(self, dom, &err))
-        goto wait;
+        goto cleanup;
 
     ret = VIRT_VIEWER_APP_CLASS(virt_viewer_parent_class)->initial_connect(app, &err);
     if (ret || err)
-- 
2.3.3




More information about the virt-tools-list mailing list