[virt-tools-list] [virt-manager PATCH] virt-manager: fix --show-host-summary error windows flooding

[Giuseppe Scrivano]

Cole Robinson <crobinso at redhat.com> writes:

> On 05/11/2015 09:30 AM, Giuseppe Scrivano wrote:
>> Break an endless loop vmmHost.overview_name_changed ->
>> vmmHost.conn_state_changed -> vmmHost._overview_name_changed.
>> 
>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1220322
>> 
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>>  virtManager/connection.py | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
>> 
>> diff --git a/virtManager/connection.py b/virtManager/connection.py
>> index eb6825b..c229a9f 100644
>> --- a/virtManager/connection.py
>> +++ b/virtManager/connection.py
>> @@ -1322,7 +1322,8 @@ class vmmConnection(vmmGObject):
>>          self.config.set_conn_autoconnect(self.get_uri(), val)
>>  
>>      def set_config_pretty_name(self, value):
>> -        self.config.set_perconn(self.get_uri(), "/pretty-name", value)
>> +        if value != self._get_config_pretty_name():
>> +            self.config.set_perconn(self.get_uri(), "/pretty-name", value)
>>      def _get_config_pretty_name(self):
>>          return self.config.get_perconn(self.get_uri(), "/pretty-name")
>>      def _on_config_pretty_name_changed(self, *args, **kwargs):
>> 
>
> ACK

thanks, pushed now.

Giuseppe