[virt-tools-list] [virt-manager PATCH] virt-install: always enable pae for xen hvm 64bit guest

[Cole Robinson]

On 11/03/2015 07:15 AM, Pavel Hrdina wrote:
> According to xen documentation 64bit guest has to have pae enabled in
> order to be able to run 64bit OS.
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1267160
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  tests/cli-test-xml/compare/virt-install-xen-hvm.xml | 1 +
>  virtinst/guest.py                                   | 7 ++++++-
>  2 files changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/cli-test-xml/compare/virt-install-xen-hvm.xml b/tests/cli-test-xml/compare/virt-install-xen-hvm.xml
> index 41f03c0..746cce8 100644
> --- a/tests/cli-test-xml/compare/virt-install-xen-hvm.xml
> +++ b/tests/cli-test-xml/compare/virt-install-xen-hvm.xml
> @@ -13,6 +13,7 @@
>    <features>
>      <acpi/>
>      <apic/>
> +    <pae/>
>    </features>
>    <clock offset="utc"/>
>    <on_poweroff>destroy</on_poweroff>
> diff --git a/virtinst/guest.py b/virtinst/guest.py
> index 6f2b30a..ec66f7a 100644
> --- a/virtinst/guest.py
> +++ b/virtinst/guest.py
> @@ -881,7 +881,12 @@ class Guest(XMLBuilder):
>          if self.features.apic == "default":
>              self.features.apic = self.capsinfo.guest.supports_apic()
>          if self.features.pae == "default":
> -            self.features.pae = self.capsinfo.guest.supports_pae()
> +            if (self.os.is_hvm() and
> +                self.type == "xen" and
> +                self.os.arch == "x86_64"):
> +                self.features.pae = True
> +            else:
> +                self.features.pae = self.capsinfo.guest.supports_pae()
>  
>          if (self.features.vmport == "default" and
>              self.os.is_x86() and
> 

ACK

- Cole