[virt-tools-list] [PATCH 3/5] Update gitignore

[Eduardo Lima (Etrunko)]

On 11/03/2015 10:57 AM, Christophe Fergeau wrote:
> Hey,
> 
> On Tue, Nov 03, 2015 at 09:38:24AM -0200, Eduardo Lima (Etrunko) wrote:
>>
>> Yes, you can find those in the final Makefile, but test-driver is the
>> only one missing. Maybe a bug in automake?
> 
> Makefile.am has a MAINTAINERCLEANFILES variable with all these build-aux
> files listed except for test-driver, the bug would be there. Now that I
> experimented a bit more with this, all these build-aux files are covered
> by one of:
> 
>  MAINTAINERCLEANFILES =                         \
> +       $(GITIGNORE_MAINTAINERCLEANFILES_TOPLEVEL) \
> +       $(GITIGNORE_MAINTAINERCLEANFILES_MAKEFILE_IN) \
> +       $(GITIGNORE_MAINTAINERCLEANFILES_M4_LIBTOOL)  \
> (sorry dunno which one ;)
>

Ah right, I have missed the declaration of files under build-aux/ above,
I will take a look on those variables to check which one should be used.

>>>
>>> Same interrogation as Fidencio here. Are you updating git.mk from
>>> 'upstream', or was it changed for a different reason?
>>>
>>
>> git.mk assumes that the po/ directory is located under src/, not in the
>> root directory, as it happens for virt-viewer. I ended up getting the
>> whole lot of untracked files under po/ after running 'make distcheck',
>> can you try it and see if it happens for you too?
> 
> I haven't been able to reproduce this.
>

I wonder if there is some package missing in my system that is causing
this kind of differences between my environment and both of yours.


> 
> Actually, updating git.mk to the latest version seems to fix this
> particular issue with no changes on virt-viewer side
> https://github.com/behdad/git.mk
> 


Ok, so I guess I will start by updating that file.


Regards, Eduardo.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com