[virt-tools-list] [PATCH v2 0/6] [virt-viewer] Some cosmetic fixes

Eduardo Lima (Etrunko) etrunko at redhat.com
Thu Nov 5 15:42:55 UTC 2015


Daniel,

On 11/05/2015 12:27 PM, Daniel P. Berrange wrote:
> On Wed, Nov 04, 2015 at 12:32:41PM -0200, Eduardo Lima (Etrunko) wrote:
>> Resend of my cleanup series, please take a look. In this new version,
>> I have found what was causing the errors running autogen.sh and updated
>> git.mk from upstream.
> 
> This series broke the build on older RHEL because the m4/ directory
> no longer exists in a clean checkout. The solution is to mkdir -p m4
> in autogen.sh.
> 
> It also fails 'make syntax-check' on all platforms - please ensure
> 'make sytnax-check' passes before pushing any code to git master.
> 
> I've pushed changes to fix both these build problems.
> 
> Regards,
> Daniel
> 

Thank you for the fixes. I was not aware of syntax-check, so I guess it
would be interesting to submit the git.mk changes to upstream author.

http://github.com/behdad/git.mk

Regards, Eduardo.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko at redhat.com




More information about the virt-tools-list mailing list