[virt-tools-list] [virt-manager PATCH] virtinst.connection: detect RHEL system also for session connection

Pavel Hrdina phrdina at redhat.com
Fri Nov 6 09:49:02 UTC 2015


On Thu, Nov 05, 2015 at 12:29:41PM -0500, Cole Robinson wrote:
> On 11/05/2015 07:54 AM, Pavel Hrdina wrote:
> > We should detect RHEL qemu also for session connection, not only system
> > connection, the capabilities of both are the same.
> > 
> > Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1258691
> > 
> > Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> > ---
> > 
> > I'm not sure, why there was only qemu_system, I've tried to follow the change to
> > its origin, but it didn't help.
> > 
> 
> I don't think there's any good reason TBH
> 
> ACK

Thanks,
    
Pavel

> 
> - Cole
> 
> >  virtinst/connection.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/virtinst/connection.py b/virtinst/connection.py
> > index aef7b48..a09f4df 100644
> > --- a/virtinst/connection.py
> > +++ b/virtinst/connection.py
> > @@ -326,7 +326,7 @@ class VirtualConnection(object):
> >          if not CLIConfig.stable_defaults and not force:
> >              return False
> >  
> > -        if not self.is_qemu_system():
> > +        if not self.is_qemu():
> >              return False
> >  
> >          if emulator:
> > 
> 




More information about the virt-tools-list mailing list