[virt-tools-list] [PATCH] msi: {virt, remote}-viewer depends on libxml2

Fabiano Fidêncio fidencio at redhat.com
Tue Oct 6 21:15:00 UTC 2015

Currently libxml2 is pulled as an indirect dependency when virt-viewer
is built with support to ovirt or libvirt (pulled by rest or libvirt,
respectively). However, {virt,remote}-viewer itself depends on libxml2
and not having it as an explicit dependency will cause errors on opening
remote-viewer when it is built without support to ovirt/libvirt.
 data/virt-viewer.wxs.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/data/virt-viewer.wxs.in b/data/virt-viewer.wxs.in
index 48ef4ca..2ed3b93 100644
--- a/data/virt-viewer.wxs.in
+++ b/data/virt-viewer.wxs.in
@@ -29,6 +29,7 @@
   <?if $(var.HaveOVirt) = "True"?>
     <?require libgovirt.wxi?>
+  <?require libxml2.wxi?>
   <?define UpgradeCode = "5B027138-1A63-49E6-877E-055E5EEC1903"?>
   <Product Id="*"
@@ -135,6 +136,7 @@
       <?if $(var.HaveOVirt) = "True"?>
         <ComponentGroupRef Id="CG.libgovirt"/>
+      <ComponentGroupRef Id="CG.libxml2"/>
       <ComponentGroupRef Id="CG.virt-viewer"/>
       <ComponentRef Id="CDepsFile"/>
       <ComponentRef Id="CShortcut"/>

More information about the virt-tools-list mailing list