[virt-tools-list] [PATCH virt-viewer v2] Adapt to spice-gtk single-header include policy

Daniel P. Berrange berrange at redhat.com
Mon Oct 12 13:54:38 UTC 2015

On Mon, Oct 12, 2015 at 08:50:12AM -0500, Jonathon Jongsma wrote:
> On Mon, 2015-10-12 at 10:26 +0100, Daniel P. Berrange wrote:
> > On Fri, Oct 09, 2015 at 04:15:13PM -0500, Jonathon Jongsma wrote:
> > > Unfortunately, there was no single-header include for the GTK+ library
> > > until just recently (spice-client-gtk.h), so this requires bumping the
> > > spice-gtk version requirement to a unreleased git version.
> > 
> > IIUC this is going to prevent virt-viewer being built against existing
> > released of spice. I think this is a rather unpleasant API break for
> > SPICE to force on client programs.
> > 
> > I would really expect there to be several releases where SPICE provided
> > the new single-header that apps could use, while *also* allowing apps
> > to continue to include the more specific headers. ie, give apps some
> > grace time to switch over to the new style. Can you try and re-visit
> > this in SPICE first.
> Actually, the only changes I have pushed to spice are those that:
> - add this new spice-client-gtk.h master header
> - produce a compiler #warning when including one of the sub-headers
> So, at the moment, it is still possible to build virt-viewer against
> both released and unreleased (git master) spice-gtk. In the latter case,
> we'll just get compile warnings. This patch adds a dependency on git
> master to try to avoid those warnings. But we can delay this patch and
> simply live with the warnings for a little while if that's what people
> prefer.

My general desire is that virt-viewer *always* be capable of building
against the most recent Fedora stable branch, because when I build
release binaries (eg for Win32) I don't want to be using unreleased
code or Fedora rawhide. I want to use a known good stable Fedora release
Mingw toolchain.

|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|

More information about the virt-tools-list mailing list