[virt-tools-list] [virt-viewer] nsis: Only search for libvirt dir when built with libvirt support

Christophe Fergeau cfergeau at redhat.com
Mon Apr 25 12:55:29 UTC 2016


On Mon, Apr 25, 2016 at 02:48:55PM +0200, Fabiano Fidêncio wrote:
> On Mon, Apr 25, 2016 at 2:45 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> > On Mon, Apr 25, 2016 at 02:26:40PM +0200, Fabiano Fidêncio wrote:
> >> Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> >> ---
> >>  data/virt-viewer.nsis.in | 4 +++-
> >>  1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/data/virt-viewer.nsis.in b/data/virt-viewer.nsis.in
> >> index 1853a0f..f032897 100755
> >> --- a/data/virt-viewer.nsis.in
> >> +++ b/data/virt-viewer.nsis.in
> >> @@ -177,7 +177,9 @@ Section "VirtViewer"
> >>    SetOutPath "$INSTDIR\etc"
> >>    File /r "@prefix@/etc/fonts"
> >>    File /r "@prefix@/etc/gtk-3.0"
> >> -  File /r "@prefix@/etc/libvirt"
> >> +  !if ${HaveLibvirt} == True
> >> +    File /r "@prefix@/etc/libvirt"
> >> +  !endif
> >>
> >>    CreateDirectory "$INSTDIR\etc\gtk-3.0"
> >
> >
> > Acked-by: Christophe Fergeau <cfergeau at redhat.com>
> > I assume this is the only change needed to get libvirt-less nsis
> > installers to work? Or is there more work needed there?
> 
> The work was done more than one year ago, please, take a look on: 5159956305c3f
> This part was a leftover :-\

Ah ok, might be worth mentioning this in the commit log (that it's
something which was missed as part of commit 5159956305c3f )

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160425/3a2bfa42/attachment.sig>


More information about the virt-tools-list mailing list