[virt-tools-list] [PATCH virt-viewer] README: update information

Fabiano Fidêncio fabiano at fidencio.org
Tue Feb 23 14:39:14 UTC 2016


On Tue, Feb 23, 2016 at 3:07 PM, Pavel Grunt <pgrunt at redhat.com> wrote:
> Remove info about gtk versions
> Fix a typo
> Change link for spice-gtk widget
> ---
>  README | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/README b/README
> index 289bc86..99669a2 100644
> --- a/README
> +++ b/README
> @@ -4,17 +4,11 @@
>  Virt Viewer provides a graphical viewer for the guest OS
>  display. At this time is supports guest OS using the VNC
>  or SPICE protocols. Further protocols may be supported in
> -the future as user demand dicatates. The viewer can connect
> +the future as user demand dictates. The viewer can connect
>  directly to both local and remotely hosted guest OS, optionally
>  using SSL/TLS encryption.
>
> -Virt Viewer can be built with either GTK2 or GTK3, with the
> -default option currently being GTK2. The choice can be made
> -with:
> -
> -   ./configure --with-gtk=3.0  (or =2.0)

IMO we should keep the info about using GTK3 and, maybe, point to the
v3-maint branch in case user wants GTK2, being clear that no new
development will be done there.

> -
> -Virt Viewer uses the GTK-VNC (>= 0.4.3) widget to provide a
> +Virt Viewer uses the GTK-VNC (>= 0.4.0) widget to provide a
>  display of the VNC protocol, which is available from
>
>    http://gtk-vnc.sourceforge.net/
> @@ -22,7 +16,7 @@ display of the VNC protocol, which is available from
>  Virt Viewer uses the SPICE-GTK (>= 0.30) widget to provide a
>  display of the SPICE protocol, which is available from:
>
> -  http://spice-space.org/page/Spice-Gtk
> +  http://www.spice-space.org/download.html
>
>  Use of either SPICE-GTK or GTK-VNC can be disabled at time
>  of configure, with --without-gtk-vnc or --without-spice-gtk
> --
> 2.5.0
>
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

The patch is fine with or without my suggestion.

Acked-by: Fabiano Fidêncio <fidencio at redhat.com>
-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list