[virt-tools-list] [virt-viewer 0/3] Bring back libvirt-glib dependency

Victor Toso lists at victortoso.com
Thu Feb 25 21:14:56 UTC 2016


Hi,

Series looks good!
Acked-by: Victor Toso <victortoso at redhat.com>

On Tue, Feb 23, 2016 at 03:32:04PM +0100, Fabiano Fidêncio wrote:
> A long time ago we used to depend on libvirt-glib for the glib event
> loop integration. On commit 296f91c it got dropped in favor of
> keeping everything into virt-viewer tree because libvirt-glib was not
> mature enough. Well, that's not the case anymore, so let's bring
> the dependency back.
>
> You also can find patches for the nsis and msi installlers.
> A patch for msitools was already pushed and a new build including it
> is already done.
>
> Please, if testing the windows build, be aware that you'll need the
> next coming patch (not sent yet) and the msitools[0] and
> mingw-gstreamer1-plugins-bad-free[1] that has been broken for a while
> due to a mingw-nettle update (and that's what the next patch is about).
>
> [0]: http://koji.fedoraproject.org/koji/buildinfo?buildID=738266
> [1]: http://koji.fedoraproject.org/koji/buildinfo?buildID=738205
>
> Fabiano Fidêncio (3):
>   Bring back libvirt-glib dependency
>   nsis: Add libvirt-glib-1.0-0.dll
>   wxi: virt-viewer depends on libvirt-glib
>
>  configure.ac              |   5 +-
>  data/virt-viewer.nsis.in  |   2 +
>  data/virt-viewer.wxs.in   |   2 +
>  mingw-virt-viewer.spec.in |   4 +-
>  src/Makefile.am           |   4 +-
>  src/virt-viewer-events.c  | 459 ----------------------------------------------
>  src/virt-viewer-events.h  |  37 ----
>  src/virt-viewer.c         |   4 +-
>  virt-viewer.spec.in       |   1 +
>  9 files changed, 16 insertions(+), 502 deletions(-)
>  delete mode 100644 src/virt-viewer-events.c
>  delete mode 100644 src/virt-viewer-events.h
> 
> -- 
> 2.5.0
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list




More information about the virt-tools-list mailing list