[virt-tools-list] [virt-viewer] session-vnc: Avoid depracated warnings on this file

Jonathon Jongsma jjongsma at redhat.com
Fri Feb 26 16:57:31 UTC 2016



On Fri, 2016-02-26 at 17:26 +0100, Pavel Grunt wrote:
> On Fri, 2016-02-26 at 17:22 +0100, Fabiano Fidêncio wrote:
> > This is a temporary solution for using autobuild.sh, as commit
> > df403f5
> > introduced the -Wdeprecated-declarations and gtk-vnc provides
> > callbacks
> > using a deprecated structure (GValueArray), forcing virt-viewer to
> > keep
> > using deprecated methods (g_value_array_*).
> > 
> > Signed-off-by: Fabiano Fidêncio <fidencio at redhat.com>
> 
> Acked-by: Pavel Grunt <pgrunt at redhat.com>


perhaps worth adding a comment to the code explaining why this is used though?


> 
> > ---
> >  src/virt-viewer-session-vnc.c | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/src/virt-viewer-session-vnc.c b/src/virt-viewer-session-
> > vnc.c
> > index 3321fc2..ccb08b2 100644
> > --- a/src/virt-viewer-session-vnc.c
> > +++ b/src/virt-viewer-session-vnc.c
> > @@ -24,6 +24,8 @@
> >  
> >  #include <config.h>
> >  
> > +#define GLIB_DISABLE_DEPRECATION_WARNINGS
> > +
> >  #include "virt-viewer-auth.h"
> >  #include "virt-viewer-session-vnc.h"
> >  #include "virt-viewer-display-vnc.h"
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list




More information about the virt-tools-list mailing list