[virt-tools-list] [PATCH] Don't open the default display while parsing command line

Fabiano Fidêncio fabiano at fidencio.org
Fri Feb 26 21:25:52 UTC 2016


On Fri, Feb 26, 2016 at 10:24 PM, Fabiano Fidêncio <fabiano at fidencio.org> wrote:
> On Fri, Feb 26, 2016 at 9:04 PM, Eduardo Lima (Etrunko)
> <etrunko at redhat.com> wrote:
>> Since commit a9ce19f it has not been possible to check app version from
>> a tty without X session running. The issue is that gtk_get_option_group
>> function opens the default display if passed TRUE as argument.
>>
>> Signed-off-by: Eduardo Lima (Etrunko) <etrunko at redhat.com>
>> ---
>>  src/virt-viewer-app.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
>> index d31acd3..3fa80a5 100644
>> --- a/src/virt-viewer-app.c
>> +++ b/src/virt-viewer-app.c
>> @@ -1920,7 +1920,7 @@ virt_viewer_app_local_command_line (GApplication   *gapp,
>>      g_option_context_set_main_group(context, group);
>>      VIRT_VIEWER_APP_GET_CLASS(self)->add_option_entries(self, context, group);
>>
>> -    g_option_context_add_group(context, gtk_get_option_group(TRUE));
>> +    g_option_context_add_group(context, gtk_get_option_group(FALSE));
>>
>>  #ifdef HAVE_GTK_VNC
>>      g_option_context_add_group(context, vnc_display_get_option_group());
>> --
>> 2.5.0
>>
>> _______________________________________________
>> virt-tools-list mailing list
>> virt-tools-list at redhat.com
>> https://www.redhat.com/mailman/listinfo/virt-tools-list
>
> Acked-by: Fabiano Fidêncio <fidencio at redhat.com>
>
> --
> Fabiano Fidêncio

Pushed,
Thanks!
-- 
Fabiano Fidêncio




More information about the virt-tools-list mailing list