[virt-tools-list] [virt-manager PATCH] connection: fix detection that libvirtd is stopped

Cole Robinson crobinso at redhat.com
Fri Jan 8 03:51:02 UTC 2016


On 01/06/2016 04:47 AM, Pavel Hrdina wrote:
> In case that libvirtd is stopped, we could receive another type of error
> from libvirt "libvirtError: internal error: client socket is closed".
> This one is usually reported from local connection.
> 
> Resloves: https://bugzilla.redhat.com/show_bug.cgi?id=1273289
> 
> Signed-off-by: Pavel Hrdina <phrdina at redhat.com>
> ---
>  virtManager/connection.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/virtManager/connection.py b/virtManager/connection.py
> index b8694af..bd604b9 100644
> --- a/virtManager/connection.py
> +++ b/virtManager/connection.py
> @@ -1298,6 +1298,7 @@ class vmmConnection(vmmGObject):
>          from_remote = getattr(libvirt, "VIR_FROM_REMOTE", None)
>          from_rpc = getattr(libvirt, "VIR_FROM_RPC", None)
>          sys_error = getattr(libvirt, "VIR_ERR_SYSTEM_ERROR", None)
> +        internal_error = getattr(libvirt, "VIR_ERR_INTERNAL_ERROR", None)
>  
>          dom = -1
>          code = -1
> @@ -1309,7 +1310,7 @@ class vmmConnection(vmmGObject):
>              self.get_uri(), exc_info=True)
>  
>          if (dom in [from_remote, from_rpc] and
> -            code in [sys_error]):
> +            code in [sys_error, internal_error]):
>              e = None
>              logging.debug("Not showing user error since libvirtd "
>                  "appears to have stopped.")
> 

ACK

- Cole




More information about the virt-tools-list mailing list