[virt-tools-list] [PATCH] window: Do not allow resizing when not in "Normal Size"

[Jonathon Jongsma]

I agree that disabling resize when zoom is enabled makes some things simpler
from an implementation perspective, but I don't think it's a good idea. 

>From a user's point of view, there's no obvious reason why zooming should
disable resizing, so they won't expect it. The more astute users may notice a
correlation between zoom enabled and resize not working, but most users will
probably just think resizing stopped working randomly. So we'll probably
suddenly start getting complaints that resizing stopped working.

>From a developer point of view, it makes it much more difficult to test
resolutions that are higher than your physical client monitor.

Jonathon

On Tue, 2016-01-12 at 11:42 +0100, Fabiano Fidêncio wrote:
> Our zoom treatment increases/decreases the window size according to the
> action fo zooming in/out. Having it in mind, resizing a window that has
> a specified zoom level set may trigger undesired behaviors like:
> - too high resolution when zooming in for several times and then
>   increasing the window size (black stripes may appear)
> - too low resolution when zooming out for several times and then
>   decreasing the window size (undesired resizing may happen)
> ---
>  src/virt-viewer-window.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index a1b9940..2ab372b 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -1419,6 +1419,7 @@ virt_viewer_window_set_zoom_level(VirtViewerWindow
> *self, gint zoom_level)
>      virt_viewer_display_set_zoom_level(VIRT_VIEWER_DISPLAY(priv->display),
> priv->zoomlevel);
>  
>      virt_viewer_window_queue_resize(self);
> +    gtk_window_set_resizable(GTK_WINDOW(self->priv->window), priv->zoomlevel
> == 100);
>  }
>  
>  gint virt_viewer_window_get_zoom_level(VirtViewerWindow *self)