[virt-tools-list] [virt-manager][PATCH] test: Adapt to new libvirt

[Cole Robinson]

On 01/29/2016 05:16 AM, Michal Privoznik wrote:
> In libvirt commit 36785c7e775f3 the input devices are no longer
> added by default in XML parsing phase rather than on domain
> startup. However, we are not starting a domain just merely
> playing around with its definition. Therefore we should adjust
> expected outputs.
> 
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> 
> So the libvirt commit I'm referring to is not yet part of any release. Having
> said that, is this the right way to fix the problem?
> 

Hmm, kindof. I try to keep the test suite working (not failing) on latest
fedora packages. with this change the tests would work on libvirt.git/1.3.2+
but fail for everything else.

Normally in these cases I'll add a bit to the affected test cases that says
'skip this test unless libvirt >= $VERSION'. grep for compare_check in
tests/clitest.py .

I tried coming up with a way to alter testdriver.xml so it would work in both
cases, but indeed the libvirt <input> XML output was sufficiently weird before
that latest commit that there isn't any way to make it work.

So I've applied your patch, and added this additional commit, see attached.

Thanks,
Cole
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-clitest-Skip-updated-tests-on-older-libvirt.patch
Type: text/x-diff
Size: 2446 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160129/d8c95ced/attachment.bin>