[virt-tools-list] [PATCH virt-viewer 03/11] ovirt-foreign-menu: Remove timer used to refresh iso list

Christophe Fergeau cfergeau at redhat.com
Wed Jul 20 07:17:44 UTC 2016


On Tue, Jul 19, 2016 at 02:35:42PM -0300, Eduardo Lima (Etrunko) wrote:
> On 07/19/2016 12:11 PM, Christophe Fergeau wrote:
> > On Mon, Jul 18, 2016 at 10:18:14AM -0300, Eduardo Lima (Etrunko) wrote:
> >> On 07/18/2016 09:14 AM, Pavel Grunt wrote:
> >>> On Sun, 2016-07-17 at 23:13 -0300, Eduardo Lima (Etrunko) wrote:
> >>>> With the new ISO dialog, the user triggers the refresh manually.
> >>>
> >>> This should come after the dialog is introduced> 
> >>
> >> Well, I have no plans in merging any of these patches independently,
> >> they are only split so that it makes more sense to understand the whole
> >> series.
> > 
> > I agree with Pavel, the series makes more sense if it's removed _after_
> > the dialog is there. But if it's a conflict mess to move it later, let's
> > keep it here.
> > 
> 
> I will try reordering the commits this way. My initial idea was to merge
> the series as a whole with --no-ff.

Given that patch5 is removing the old menu anyway, this patch can probably stay
here.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20160720/27975dee/attachment.sig>


More information about the virt-tools-list mailing list