[virt-tools-list] [PATCH virt-viewer v3 00/10] Replace oVirt foreign menu with dedicated dialog

Eduardo Lima (Etrunko) etrunko at redhat.com
Fri Jul 29 21:40:23 UTC 2016


I have pushed the first two patches of the series because they were
already acknowledged and were pretty much self-contained.

I tried to replace GtkTreeView in favor of new GtkListBox, but after some
painful work, I decided to drop it because it is not possible to
reproduce the exact same behavior of the former with the latter. For
instance, once we have a GtkRadioButton activated, it is not possible to
deactivate it. We also need to create a new GObject that would be used
as the model, while with a tree view, things can be automatically done
with Glade. Finally, it would be necessary to raise the requirements for
both gtk+ (3.16) and glib (2.44). If some one wants to take a look on
the work in progress, check out the 'dialog' branch in my github clone
(http://github.com/etrunko/virt-viewer).

In this version:

 * Removed leftover enum when changed from GtkNotebook to GtkStack
 * Some cosmetic fixes (indentation, renaming, etc)
 * UI Tweaks:
   - Added some padding between items of the list.
   - Set tree view selection to current ISO when the list is first loaded
     or refreshed.
   - Handle tree view "activate" signal the same way as radio button
     toggle
   - Removed "Select ISO" label and alignment in header bar patch.

Eduardo Lima (Etrunko) (10):
  ovirt-foreign-menu: Remove timer used to refresh iso list
  ovirt-foreign-menu: Add accessors for current iso and iso list
  ovirt-foreign-menu: Remove GtkMenu related functions
  ovirt-foreign-menu: Notify of new files even if nothing changed
  UI: Make 'Change CD' menu item a submenu under 'File' toplevel menu
  Introduce ISO List dialog
  Run iso-dialog when 'Change CD' menu is activated
  remote-viewer: Make ovirt-foreign-menu a property
  iso-dialog: Implement functionality provided by oVirt foreign menu
  iso-dialog: Use header bar for buttons

 configure.ac                               |   4 +-
 po/POTFILES.in                             |   2 +
 src/Makefile.am                            |   3 +
 src/ovirt-foreign-menu.c                   | 182 +++++------------
 src/ovirt-foreign-menu.h                   |   5 +-
 src/remote-viewer-iso-list-dialog.c        | 316 +++++++++++++++++++++++++++++
 src/remote-viewer-iso-list-dialog.h        |  58 ++++++
 src/remote-viewer.c                        |  89 ++++----
 src/resources/ui/remote-viewer-iso-list.ui | 135 ++++++++++++
 src/resources/ui/virt-viewer.ui            |  19 +-
 src/resources/virt-viewer.gresource.xml    |   1 +
 src/virt-viewer-window.c                   |  37 ++++
 12 files changed, 660 insertions(+), 191 deletions(-)
 create mode 100644 src/remote-viewer-iso-list-dialog.c
 create mode 100644 src/remote-viewer-iso-list-dialog.h
 create mode 100644 src/resources/ui/remote-viewer-iso-list.ui

-- 
2.7.4




More information about the virt-tools-list mailing list